-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Fedora 39 #1490 #2719
Move to Fedora 39 #1490 #2719
Conversation
This is looking close! I think we also want the Also, it looks like there's some minor end of file newline differences in the lockfiles (this is minor but it shows up in a
|
manifest-lock.overrides.yaml
Outdated
selinux-policy: | ||
evra: 39.1-1.fc39.noarch | ||
metadata: | ||
bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2023-24872e50a0 | ||
reason: https://github.com/coreos/fedora-coreos-tracker/issues/1490#issuecomment-1720020468 | ||
type: fast-track | ||
selinux-policy-targeted: | ||
evra: 39.1-1.fc39.noarch | ||
metadata: | ||
bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2023-24872e50a0 | ||
reason: https://github.com/coreos/fedora-coreos-tracker/issues/1490#issuecomment-1720020468 | ||
type: fast-track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that next-devel
just dropped this in #2718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that. Fixed it.
287263a
to
2912bb0
Compare
Thanks for reviewing! I added the |
63840d7
to
70a0938
Compare
I have two questions: 1 - In the
Should it be included too? 2 - The other question is about the red circles in my PR who suggest that there is a empty line in some files. I already fix it in my vscode settings and committed applying the changes, but is still appearing here. Do you have any idea how to solve it? Thanks 😸 |
For now, no. We may remove that bit soon separately (see #2690).
Hmm, I'm not sure. It may still be VS Code playing tricks. The surest way to squash those is to do it from the command-line instead using the commands I provided in #2719 (comment). |
1b55dbe
to
5de82fe
Compare
@jlebon I was able to fix it, finally. I think everything is okay now. |
OK, this is looking great! But the |
5de82fe
to
3dcaceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this!
This reverts commit cb8d722.
Bump releasever in manifest.yam,bump the version in dockerfile and tests, sync the lockfiles for all arches from next-devel for Fedora 39 release.
The merge-base changed after approval.
3dcaceb
to
fd57e76
Compare
This PR, detailed in Issue , follows the necessary steps to prepares for the upcoming Fedora CoreOS 39 GA release by updating fedora-coreos-config.
FYI: Previously, there was another branch, but I set it as a draft and started working on this new one after running into some issues with the rebase. If you'd like to review the discussion on that pull request, please feel free to do so.